Bug 41020

Summary: Slider labels do not update as you move the sliders on this page
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: Layout and RenderingAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: hyatt, mitz
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: OS X 10.5   
URL: http://slides.html5rocks.com/#slide39
Attachments:
Description Flags
Testcase
none
Patch
none
Patch mitz: review+

Simon Fraser (smfr)
Reported 2010-06-22 16:21:09 PDT
Load http://slides.html5rocks.com/#slide39 and play with the box-shadow sliders. Note how the numbers next to the sliders fail to update when moving the slider thumb. However, we do move the slider around as if we were doing layout. The text-shadow sliders work OK.
Attachments
Testcase (996 bytes, text/html)
2010-08-19 12:17 PDT, Simon Fraser (smfr) 		no flags
Details
Patch (10.88 KB, patch)
2010-08-19 14:26 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (7.43 KB, patch)
2010-08-20 11:35 PDT, Simon Fraser (smfr) 		mitz: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
mitz
Comment 1 2010-06-22 16:32:26 PDT
This only happens in the two-column configuration. If I disable the -webkit-column-count: 2; property, I don’t see the problem.
Simon Fraser (smfr)
Comment 2 2010-08-19 12:17:21 PDT
Created attachment 64886 [details] Testcase
Simon Fraser (smfr)
Comment 3 2010-08-19 12:18:23 PDT
The issue is that 'repaintTop', returned by layoutInlineChildren(), doesn't take columns into account.
Simon Fraser (smfr)
Comment 4 2010-08-19 12:21:50 PDT
Ah, this would be: // FIXME: Deal with multiple column repainting. We have to split the repaint // rect up into multiple rects if it spans columns. in RenderBlock::layoutBlock()
Simon Fraser (smfr)
Comment 5 2010-08-19 14:26:09 PDT
Created attachment 64899 [details] Patch
Simon Fraser (smfr)
Comment 6 2010-08-20 11:00:20 PDT
Comment on attachment 64899 [details] Patch Going to update this based on feedback from hyatt.
Simon Fraser (smfr)
Comment 7 2010-08-20 11:35:05 PDT
Created attachment 64966 [details] Patch
Simon Fraser (smfr)
Comment 8 2010-08-20 11:50:12 PDT
http://trac.webkit.org/changeset/65746
Note You need to log in before you can comment on or make changes to this bug.