Summary: | [EFL] Implement several notification hooks in FrameLoaderClient | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||||||||
Component: | WebKit EFL | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | barbieri, commit-queue, gyuyoung.kim, kenneth, lucas.de.marchi, webkit.review.bot | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | PC | ||||||||||||
OS: | Linux | ||||||||||||
Bug Depends on: | 40930 | ||||||||||||
Bug Blocks: | 41008 | ||||||||||||
Attachments: |
|
Description
Lucas De Marchi
2010-06-22 12:27:16 PDT
Created attachment 59403 [details]
This patch does not applying without applying #40930 first, so I'm not setting r? not to bother style bot. I hope someone review that one quickly.
Created attachment 59404 [details]
Patch
Wrong argument to webkit-patch. Fixing filename.
Attachment 59404 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/efl/ewk/ewk_private.h:55: Extra space between void and ewk_view_load_provisional [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:57: Extra space between void and ewk_view_frame_main_cleared [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:58: Extra space between void and ewk_view_frame_main_icon_received [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:62: Extra space between void and ewk_view_load_show [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:63: Extra space between void and ewk_view_restore_state [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:121: Extra space between void and ewk_frame_load_provisional [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:122: Extra space between void and ewk_frame_load_firstlayout_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:123: Extra space between void and ewk_frame_load_firstlayout_nonempty_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:124: Extra space between void and ewk_frame_load_document_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:129: Extra space between void and ewk_frame_request_will_send [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:130: Extra space between void and ewk_frame_request_assign_identifier [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:131: Extra space between void and ewk_frame_view_state_save [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:133: Extra space between void and ewk_frame_did_perform_first_navigation [whitespace/declaration] [3]
Total errors found: 13 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 59404 [details]
Patch
Looks good to me. Lots of new useful API :-)
Comment on attachment 59404 [details] Patch Rejecting patch 59404 from commit-queue. Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'Kenneth Rohde Christiansen', u'--force']" exit_code: 1 Last 500 characters of output: at 478 (offset 2 lines). Hunk #5 succeeded at 567 (offset 2 lines). Hunk #6 succeeded at 581 (offset 2 lines). Hunk #7 FAILED at 621. 1 out of 7 hunks FAILED -- saving rejects to file WebKit/efl/WebCoreSupport/FrameLoaderClientEfl.cpp.rej patching file WebKit/efl/ewk/ewk_frame.cpp Hunk #2 succeeded at 1634 (offset -9 lines). Hunk #3 succeeded at 1717 (offset -9 lines). patching file WebKit/efl/ewk/ewk_frame.h patching file WebKit/efl/ewk/ewk_private.h Hunk #2 succeeded at 123 (offset 5 lines). Full output: http://webkit-commit-queue.appspot.com/results/3400371 Created attachment 60773 [details]
Patch
Created attachment 60775 [details]
Patch
Attachment 60775 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit/efl/ewk/ewk_private.h:55: Extra space between void and ewk_view_load_provisional [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:57: Extra space between void and ewk_view_frame_main_cleared [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:58: Extra space between void and ewk_view_frame_main_icon_received [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:62: Extra space between void and ewk_view_load_show [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:63: Extra space between void and ewk_view_restore_state [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:126: Extra space between void and ewk_frame_load_provisional [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:127: Extra space between void and ewk_frame_load_firstlayout_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:128: Extra space between void and ewk_frame_load_firstlayout_nonempty_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:129: Extra space between void and ewk_frame_load_document_finished [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:134: Extra space between void and ewk_frame_request_will_send [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:135: Extra space between void and ewk_frame_request_assign_identifier [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:136: Extra space between void and ewk_frame_view_state_save [whitespace/declaration] [3]
WebKit/efl/ewk/ewk_private.h:138: Extra space between void and ewk_frame_did_perform_first_navigation [whitespace/declaration] [3]
Total errors found: 13 in 5 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 60775 [details] Patch Clearing flags on attachment: 60775 Committed r62787: <http://trac.webkit.org/changeset/62787> All reviewed patches have been landed. Closing bug. |