Bug 40990

Summary: [GTK] Bots are showing lots of GTK_IS_CONTAINER critical warnings
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Attachments:
Description Flags
Patch for this issue
none
Another approach to this issue gustavo: review+

Martin Robinson
Reported 2010-06-22 09:39:33 PDT
This seems to be an issue with ScrollViewGtk creating native scrollbars too late in the lifetime of a view. For now we can simply not add the scrollbar in that case. I think the real long term solution is to entirely remove native scrollbars and rely on the theme drawing code to render them.
Attachments
Patch for this issue (1.38 KB, patch)
2010-06-22 11:03 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Another approach to this issue (4.79 KB, patch)
2010-08-18 13:42 PDT, Martin Robinson 		gustavo: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-06-22 11:03:05 PDT
Created attachment 59391 [details] Patch for this issue
Xan Lopez
Comment 2 2010-06-24 11:56:39 PDT
Comment on attachment 59391 [details] Patch for this issue As commented on jabber, relying on a dead widget to do something or other is not a good idea. We have to find other solution.
Martin Robinson
Comment 3 2010-08-18 13:42:57 PDT
Created attachment 64764 [details] Another approach to this issue
Gustavo Noronha (kov)
Comment 4 2010-08-18 13:48:16 PDT
Comment on attachment 64764 [details] Another approach to this issue This looks sane to me, please run the API tests too. Some going around in build.webkit.org would be a plus, given how fragile this code still seems to be =(
Martin Robinson
Comment 5 2010-08-18 15:45:36 PDT
Committed r65635: <http://trac.webkit.org/changeset/65635>
WebKit Review Bot
Comment 6 2010-08-18 16:18:45 PDT
http://trac.webkit.org/changeset/65635 might have broken Chromium Mac Release The following changes are on the blame list: http://trac.webkit.org/changeset/65635 http://trac.webkit.org/changeset/65636 http://trac.webkit.org/changeset/65637
Note You need to log in before you can comment on or make changes to this bug.