Bug 40962

Summary: webkit-patch should refuse to run under Win32 Python
Product: WebKit Reporter: Dirk Pranke <dpranke>
Component: New BugsAssignee: Dirk Pranke <dpranke>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, commit-queue, eric, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch none

Dirk Pranke
Reported 2010-06-21 19:08:16 PDT
webkit-patch should refuse to run under Win32 Python
Attachments
Patch (1.59 KB, patch)
2010-06-21 19:09 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Patch (1.85 KB, patch)
2010-06-21 19:39 PDT, Dirk Pranke 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Dirk Pranke
Comment 1 2010-06-21 19:09:59 PDT
Created attachment 59322 [details] Patch
Dirk Pranke
Comment 2 2010-06-21 19:11:25 PDT
Given that there are lots of places in webkit-patch's code that assume unix-style filenames (forward slashes), webkit-patch fails with weird file-not-found errors when run under a native windows Python. It would be nice if we just trapped this and errored out at the beginning, rather than producing unpredictable errors.
Dirk Pranke
Comment 3 2010-06-21 19:39:21 PDT
Created attachment 59326 [details] Patch
Eric Seidel (no email)
Comment 4 2010-07-12 20:12:14 PDT
Comment on attachment 59326 [details] Patch OK.
Adam Barth
Comment 5 2010-08-10 22:24:52 PDT
Comment on attachment 59326 [details] Patch That's too bad.
WebKit Commit Bot
Comment 6 2010-08-10 23:19:51 PDT
Comment on attachment 59326 [details] Patch Clearing flags on attachment: 59326 Committed r65126: <http://trac.webkit.org/changeset/65126>
WebKit Commit Bot
Comment 7 2010-08-10 23:19:56 PDT
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 8 2010-08-11 06:14:17 PDT
http://trac.webkit.org/changeset/65126 might have broken Leopard Intel Debug (Tests)
Note You need to log in before you can comment on or make changes to this bug.