Bug 40949

Summary: Add PluginInfoStore class
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch sam: review+

Description Anders Carlsson 2010-06-21 15:47:52 PDT
Add PluginInfoStore class
Comment 1 Anders Carlsson 2010-06-21 15:50:48 PDT
Created attachment 59301 [details]
Patch
Comment 2 Sam Weinig 2010-06-21 15:54:28 PDT
Comment on attachment 59301 [details]
Patch

> Index: WebKit2/Shared/WebPreferencesStore.h
> ===================================================================
> --- WebKit2/Shared/WebPreferencesStore.h	(revision 61578)
> +++ WebKit2/Shared/WebPreferencesStore.h	(working copy)
> @@ -43,6 +43,7 @@ struct WebPreferencesStore {
>      {
>          encoder.encode(javaScriptEnabled);
>          encoder.encode(loadsImagesAutomatically);
> +        encoder.encode(pluginsEnabled);
>          encoder.encode(minimumFontSize);
>          encoder.encode(minimumLogicalFontSize);
>          encoder.encode(defaultFontSize);
> @@ -61,6 +62,8 @@ struct WebPreferencesStore {
>              return false;
>          if (!decoder.decode(s.loadsImagesAutomatically))
>              return false;
> +        if (!decoder.decode(s.pluginsEnabled))
> +            return false;
>          if (!decoder.decode(s.minimumFontSize))
>              return false;
>          if (!decoder.decode(s.minimumLogicalFontSize))
> @@ -86,6 +89,8 @@ struct WebPreferencesStore {
>  
>      bool javaScriptEnabled;
>      bool loadsImagesAutomatically;
> +    bool pluginsEnabled;
You should mention in your changelog that you are also making this change to the preferences.

Otherwise, looks good. r=me.
Comment 3 Anders Carlsson 2010-06-21 16:00:25 PDT
Committed r61587: <http://trac.webkit.org/changeset/61587>