Summary: | [EFL] Implement methods to create a new window | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||
Component: | WebKit Misc. | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | barbieri, gyuyoung.kim, leandro, lucas.de.marchi | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | Linux | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 41005 | ||||||
Attachments: |
|
Description
Lucas De Marchi
2010-06-21 11:39:14 PDT
Created attachment 59267 [details]
Patch
I'm not a reviewer, this is an informal review. LGTM. Comment on attachment 59267 [details]
Patch
Having methods to query all properties of a type looks weird to me, but that is your API, so your call to me =). Looks right.
Comment on attachment 59267 [details] Patch Clearing flags on attachment: 59267 Committed r61706: <http://trac.webkit.org/changeset/61706> All reviewed patches have been landed. Closing bug. |