Bug 40917

Summary: [Chromium] Add a sanity test for heap profiler
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
yurys: review-
return added pfeldman: review+

Description Mikhail Naganov 2010-06-21 07:53:54 PDT 
This is to avoid breaking it next time you switch to a new debugging protocol.
Comment 1 Mikhail Naganov 2010-06-21 07:56:01 PDT 
Created attachment 59251 [details]
patch

The corresponding Chromium code is here: http://codereview.chromium.org/2846019
Comment 2 Yury Semikhatsky 2010-06-22 00:43:06 PDT 
Comment on attachment 59251 [details]
patch

WebKit/chromium/src/js/Tests.js:486
 +                  test.releaseControl();
Also return from the function, owtherwise test.fail will be called as well. 

WebKit/chromium/ChangeLog:5
 +          [Chromium] Add a sanity test for heap profiler.
Can you implement it as a layout test instead?
Comment 3 Mikhail Naganov 2010-06-22 04:29:44 PDT 
Created attachment 59359 [details]
return added

Added a 'return'. But I must note, that I ran the tests, and it looks like after it reports success, reporting a failure just doesn't count.

It seems currently impossible to implement it as a layout test, because the panel is Chromium-only, and resides in chromium platform code.
Comment 4 Mikhail Naganov 2010-06-22 05:12:40 PDT 
Manually committed as http://trac.webkit.org/changeset/61613


    2010-06-21  Mikhail Naganov  <mnaganov@chromium.org>
    
            Reviewed by Pavel Feldman.
    
            [Chromium] Add a sanity test for heap profiler.
    
            https://bugs.webkit.org/show_bug.cgi?id=40917
    
            * src/js/Tests.js:
            (.TestSuite.prototype.testHeapProfiler.findDisplayedNode):
            (.TestSuite.prototype.testHeapProfiler.findVisibleView):
            (.TestSuite.prototype.testHeapProfiler):