Bug 40913

Summary: [Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.
Product: WebKit Reporter: Mikhail Naganov <mnaganov>
Component: Web Inspector (Deprecated)Assignee: Mikhail Naganov <mnaganov>
Status: RESOLVED FIXED    
Severity: Normal CC: pfeldman, victorw, yurys
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
patch
none
lift up DEPS yurys: review+

Description Mikhail Naganov 2010-06-21 06:01:38 PDT
Continuing our journey on making a non-static version of WebDevToolsAgentClient::sendMessageToFrontendOnIOThread. After removing usage, it will be possible to remove implementation from Chromium.
Comment 1 Mikhail Naganov 2010-06-21 06:04:11 PDT
Created attachment 59245 [details]
patch
Comment 2 Mikhail Naganov 2010-06-21 06:07:00 PDT
Created attachment 59246 [details]
lift up DEPS
Comment 3 Yury Semikhatsky 2010-06-21 06:15:14 PDT
Comment on attachment 59246 [details]
lift up DEPS

WebKit/chromium/public/WebDevToolsAgentClient.h:76
 +  // FIXME: Remove after adding #include into devtools_agent_filter.cc
Please file a bug on this and add its number to the FIXME.
Comment 4 Mikhail Naganov 2010-06-21 06:44:51 PDT
Manually committed as http://trac.webkit.org/changeset/61539


    2010-06-21  Mikhail Naganov  <mnaganov@chromium.org>
    
            Reviewed by Yury Semikhatsky,
    
            [Chromium] Remove usage of static WebDevToolsAgentClient::sendMessageToFrontendOnIOThread.
    
            Also, move WebDevToolsMessageTransport to its own header file.
    
            https://bugs.webkit.org/show_bug.cgi?id=40913
    
            * DEPS:
            * WebKit.gyp:
            * public/WebDevToolsAgent.h:
            * public/WebDevToolsAgentClient.h:
            * public/WebDevToolsMessageTransport.h: Added.
            (WebKit::WebDevToolsMessageTransport::~WebDevToolsMessageTransport):
            * src/WebDevToolsAgentImpl.cpp:
            (WebKit::):