Summary: | [Qt] Performance of the QtScript API is not tested. | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Jędrzej Nowacki <jedrzej.nowacki> | ||||
Component: | JavaScriptCore | Assignee: | Jędrzej Nowacki <jedrzej.nowacki> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Enhancement | CC: | commit-queue, jedrzej.nowacki, kent.hansen, webkit.review.bot | ||||
Priority: | P2 | Keywords: | Qt, QtTriaged | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | All | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 31863 | ||||||
Attachments: |
|
Description
Jędrzej Nowacki
2010-06-21 05:48:05 PDT
Created attachment 59500 [details]
Fix v1
The patch introduces micro benchmarks for existing Api.
Attachment 59500 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
Last 3072 characters of output:
ject_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:68: isError_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:71: toString_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:73: toNumber_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:75: toBool_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:77: toInteger_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:79: toInt32_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:81: toUInt32_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:83: toUInt16_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:85: toObject_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:88: equals_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:90: strictlyEquals_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp:92: instanceOf_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptengine/tst_qscriptengine.cpp:20: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
JavaScriptCore/qt/benchmarks/qscriptengine/tst_qscriptengine.cpp:28: checkSyntax_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptengine/tst_qscriptengine.cpp:31: evaluateString_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
JavaScriptCore/qt/benchmarks/qscriptengine/tst_qscriptengine.cpp:33: evaluateProgram_data is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 27 in 9 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > If any of these errors are false positives, please file a bug against check-webkit-style. Reopened 34574 Comment on attachment 59500 [details] Fix v1 Clearing flags on attachment: 59500 Committed r61882: <http://trac.webkit.org/changeset/61882> All reviewed patches have been landed. Closing bug. |