Bug 40910

Summary: [Qt] Avoid unnecessary image conversion in RGBA32Buffer::zeroFill()
Product: WebKit Reporter: Balazs Kelemen <kbalazs>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: CLOSED FIXED    
Severity: Normal CC: benjamin, commit-queue, hausmann
Priority: P2 Keywords: Performance, Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed patch none

Balazs Kelemen
Reported 2010-06-21 05:14:46 PDT
It is totally useless to converting the QImage for the QPixmap and then fill the pixmap with zero. Instead of this we can create an empty pixmap with the appropriate dimensions and fill that.
Attachments
proposed patch (1.15 KB, patch)
2010-06-21 05:18 PDT, Balazs Kelemen 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Balazs Kelemen
Comment 1 2010-06-21 05:18:49 PDT
Created attachment 59242 [details] proposed patch
Benjamin Poulain
Comment 2 2010-06-21 05:49:54 PDT
You are right, I did an unfortunate copy-paste there.
WebKit Commit Bot
Comment 3 2010-06-21 07:08:48 PDT
Comment on attachment 59242 [details] proposed patch Clearing flags on attachment: 59242 Committed r61540: <http://trac.webkit.org/changeset/61540>
WebKit Commit Bot
Comment 4 2010-06-21 07:08:53 PDT
All reviewed patches have been landed. Closing bug.
Simon Hausmann
Comment 5 2010-06-21 07:21:51 PDT
Revision r61540 cherry-picked into qtwebkit-2.0 with commit 45d1c9149ef8940081fa8dd35854d2b95ebaf3cd
Note You need to log in before you can comment on or make changes to this bug.