| Summary: | Get rid of the extensionToMIME mapping in WebBasePluginPackage | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Carlsson <andersca> | ||||
| Component: | New Bugs | Assignee: | Anders Carlsson <andersca> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | abarth, eric, webkit.review.bot | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Other | ||||||
| OS: | OS X 10.5 | ||||||
| Attachments: |
|
||||||
|
Description
Anders Carlsson
2010-06-20 19:21:36 PDT
Created attachment 59223 [details]
Patch
Comment on attachment 59223 [details] Patch > + for (size_t i = 0; i < mimeTypes.size(); ++i) { > + const MimeClassInfo& mimeClassInfo = mimeTypes[i]; > + > + for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) { Please don’t reuse the outer loop’s index variable. > +- (NSString *)MIMETypeForExtension:(const String&)extension > { > - return [extensionToMIME objectForKey:extension]; > + ASSERT(extension.lower() == extension); > + > + for (size_t i = 0; i < mimeTypes.size(); ++i) { > + const MimeClassInfo& mimeClassInfo = mimeTypes[i]; > + > + for (size_t i = 0; i < mimeClassInfo.extensions.size(); ++i) { Diito. … > + return NO; I doubt that clang++ would allow returning NO from an (NSString *) method. Please return nil. Committed r61523: <http://trac.webkit.org/changeset/61523> http://trac.webkit.org/changeset/61523 might have broken SnowLeopard Intel Release (Tests) Looks like a real failure... Tests that caused the DumpRenderTree tool to crash: compositing/geometry/object-clip-rects-assertion.html stderr dom/html/level2/html/AppletsCollection.html stderr fast/dom/object-embed-plugin-scripting.html stderr plugins/embed-attributes-setting.html expected |