Summary: | Sheriffbot: Should allow "r" in SVN_REVISION | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Joseph Pecoraro <joepeck> | ||||
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, commit-queue, eric, joepeck, ojan, tonyg | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Joseph Pecoraro
2010-06-20 12:16:06 PDT
Created attachment 59209 [details]
Strip a Leading "r" if its there.
NOTE: I didn't run the tests! How do I run the python
tests for the irc bot?
CC'ing a bunch of people who have worked in the WebKitTools/Scripts/webkitpy/tool directory. The patch is simple enough, but see my question above about running the tests for the tools. Thanks! You can run test-webkitpy Comment on attachment 59209 [details]
Strip a Leading "r" if its there.
Lgtm
(In reply to comment #3) > You can run test-webkitpy Excellent, that worked perfectly! Has it been considered that this be renamed to match the usual run-*-tests pattern? I see there are a few like this, all for scripts: WebKitTools/Scripts/test-webkit-scripts WebKitTools/Scripts/test-webkitperl WebKitTools/Scripts/test-webkitpy You can look at the discussion on the bug where thoses were added. I think various folks preferred the test-* pattern for reasons I don't remember. (In reply to comment #6) > You can look at the discussion on the bug where thoses were added. > I think various folks preferred the test-* pattern for reasons I don't > remember. Ahh, okay. Thanks! Comment on attachment 59209 [details] Strip a Leading "r" if its there. Clearing flags on attachment: 59209 Committed r61515: <http://trac.webkit.org/changeset/61515> All reviewed patches have been landed. Closing bug. |