Bug 40889

Summary:

Sheriffbot: Should allow "r" in SVN_REVISION

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, commit-queue, eric, joepeck, ojan, tonyg

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Strip a Leading "r" if its there.	none

Joseph Pecoraro

Reported 2010-06-20 12:16:06 PDT

Situation I just had: JoePeck: sheriffbot: rollout r61506 Causes crash. Will take a different approach. sheriffbot: Preparing rollout for rr61506... sheriffbot: JoePeck: Failed to create rollout patch: sheriffbot: Invalid svn revision number "r61506". =(. Bot could be more lenient.

Attachments
Strip a Leading "r" if its there. (2.46 KB, patch) 2010-06-20 12:19 PDT, Joseph Pecoraro	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Joseph Pecoraro

Comment 1 2010-06-20 12:19:20 PDT

Created attachment 59209 [details] Strip a Leading "r" if its there. NOTE: I didn't run the tests! How do I run the python tests for the irc bot?

Joseph Pecoraro

Comment 2 2010-06-20 12:23:10 PDT

CC'ing a bunch of people who have worked in the WebKitTools/Scripts/webkitpy/tool directory. The patch is simple enough, but see my question above about running the tests for the tools. Thanks!

Adam Barth

Comment 3 2010-06-20 12:34:43 PDT

You can run test-webkitpy

Adam Barth

Comment 4 2010-06-20 12:41:47 PDT

Comment on attachment 59209 [details] Strip a Leading "r" if its there. Lgtm

Joseph Pecoraro

Comment 5 2010-06-20 12:49:11 PDT

(In reply to comment #3) > You can run test-webkitpy Excellent, that worked perfectly! Has it been considered that this be renamed to match the usual run-*-tests pattern? I see there are a few like this, all for scripts: WebKitTools/Scripts/test-webkit-scripts WebKitTools/Scripts/test-webkitperl WebKitTools/Scripts/test-webkitpy

Adam Barth

Comment 6 2010-06-20 13:04:51 PDT

You can look at the discussion on the bug where thoses were added. I think various folks preferred the test-* pattern for reasons I don't remember.

Joseph Pecoraro

Comment 7 2010-06-20 13:08:54 PDT

(In reply to comment #6) > You can look at the discussion on the bug where thoses were added. > I think various folks preferred the test-* pattern for reasons I don't > remember. Ahh, okay. Thanks!

WebKit Commit Bot

Comment 8 2010-06-20 15:51:25 PDT

Comment on attachment 59209 [details] Strip a Leading "r" if its there. Clearing flags on attachment: 59209 Committed r61515: <http://trac.webkit.org/changeset/61515>

WebKit Commit Bot

Comment 9 2010-06-20 15:51:30 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.