Summary: | Add ability to have a WebProcess per WebContext | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebKit API | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, webkit.review.bot | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-06-19 17:24:18 PDT
Created attachment 59193 [details]
patch
Attachment 59193 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebKit2/UIProcess/WebProcessManager.cpp:45: A case label should not be indented, but line up with its switch statement. [whitespace/indent] [4]
WebKit2/UIProcess/WebContext.h:35: Alphabetical sorting problem. [build/include_order] [4]
WebKit2/UIProcess/WebProcessProxy.cpp:30: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 3 in 22 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 59193 [details]
patch
r=me!
Just curious, what's the testing plan for this sort of patch? (In reply to comment #5) > Just curious, what's the testing plan for this sort of patch? As with most API-esque patches, there is not much testing going on in this area right now. I am working toward getting a DRT up and running and at some point plan on having a API testing harness, but that is still off a bit. |