Summary: | Speech Input Patch 0: Added compilation argument to conditionally compile pending patches. | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Satish Sampath <satish> | ||||||||
Component: | Forms | Assignee: | Nobody <webkit-unassigned> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | andreip, commit-queue, dimich, jorlow, levin, satish, tkent | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Bug Depends on: | |||||||||||
Bug Blocks: | 39485 | ||||||||||
Attachments: |
|
Description
Satish Sampath
2010-06-19 04:25:01 PDT
Created attachment 59185 [details]
Patch
Comment on attachment 59185 [details]
Patch
* You need to update WebKit2/Configurations/FeatureDefine.xcconfig.
WebKit/chromium/features.gypi:56
+ 'ENABLE_INPUT_SPEECH=0',
Please enable by default in order that buildbots can check compilation.
Enabling INPUT_SPEECH here doesn't mean Chromium/Chrome browser have INPUT_SPEECH.
Created attachment 59189 [details]
Patch
Added to Webkit2 config & enabled flag in chromium port
Comment on attachment 59189 [details]
Patch
LGTM. Other reviewers, any comments?
Comment on attachment 59189 [details]
Patch
Seems fine to me. r+ing
Comment on attachment 59189 [details] Patch Rejecting patch 59189 from commit-queue. Failed to run "[u'git', u'svn', u'dcommit']" exit_code: 1 Last 500 characters of output: es/win/tools/vsprops/FeatureDefinesCairo.vsprops M WebKitTools/ChangeLog M WebKitTools/Scripts/build-webkit M configure.ac A repository hook failed: MERGE request failed on '/repository/webkit/trunk': Commit blocked by pre-commit hook (exit code 1) with output: svnlook: Can't write to stream: Broken pipe The following ChangeLog files contain OOPS: trunk/WebCore/ChangeLog Please don't ever say "OOPS" in a ChangeLog file. at /usr/local/git/libexec/git-core/git-svn line 570 Full output: http://webkit-commit-queue.appspot.com/results/3284500 Created attachment 59254 [details]
Patch
Removed duplicate OOPS in changelog
Comment on attachment 59254 [details]
Patch
r=me
Comment on attachment 59254 [details] Patch Clearing flags on attachment: 59254 Committed r61545: <http://trac.webkit.org/changeset/61545> All reviewed patches have been landed. Closing bug. |