Bug 40869

Summary: Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
Product: WebKit Reporter: Anders Carlsson <andersca>
Component: New BugsAssignee: Anders Carlsson <andersca>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch mitz: review+

Description Anders Carlsson 2010-06-18 17:28:25 PDT
Change some WebPluginDabase ivars to use WebCore::String instead of NSString.
Comment 1 Anders Carlsson 2010-06-18 17:29:31 PDT
Created attachment 59171 [details]
Patch
Comment 2 Sam Weinig 2010-06-18 17:32:07 PDT
Comment on attachment 59171 [details]
Patch

r=me
Comment 3 Anders Carlsson 2010-06-18 17:35:22 PDT
Committed r61459: <http://trac.webkit.org/changeset/61459>
Comment 4 Adam Barth 2010-06-18 20:19:45 PDT
Might this have caused these tests to start timing out on Tiger?

dom/html/level2/html/AppletsCollection.html
plugins/qt-qwidget-plugin.html
Comment 5 Adam Barth 2010-06-18 20:26:04 PDT
Hum...  It's 8:30 on a Friday and I don't see you on IRC.  I'm going to try rolling this out to see if it fixes the problem.
Comment 6 Adam Barth 2010-06-18 20:36:08 PDT
Rolled out in http://trac.webkit.org/changeset/61464
Comment 7 Adam Barth 2010-06-18 20:36:32 PDT
Comment on attachment 59171 [details]
Patch

Clearing Sam's r+
Comment 8 WebKit Review Bot 2010-06-18 21:12:25 PDT
http://trac.webkit.org/changeset/61464 might have broken SnowLeopard Intel Release (Tests)
Comment 9 WebKit Review Bot 2010-06-18 22:27:31 PDT
http://trac.webkit.org/changeset/61459 might have broken Leopard Intel Debug (Tests)
The following changes are on the blame list:
http://trac.webkit.org/changeset/61458
http://trac.webkit.org/changeset/61459
Comment 10 Anders Carlsson 2010-06-20 13:18:03 PDT
Created attachment 59212 [details]
Patch
Comment 11 Anders Carlsson 2010-06-20 13:28:10 PDT
Committed r61509: <http://trac.webkit.org/changeset/61509>