Bug 40790

Summary: Fix build break with inspector disabled
Product: WebKit Reporter: Ben Murdoch <benm>
Component: Web Inspector (Deprecated)Assignee: Ben Murdoch <benm>
Status: RESOLVED FIXED    
Severity: Normal CC: android-webkit-unforking, commit-queue, pfeldman
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch. none

Ben Murdoch
Reported 2010-06-17 10:46:44 PDT
With the inspector not enabled, the build breaks due to the #include of InspectorValues.h in InspectorController.h because the content of InspectorValues is guarded by #if ENABLE(INSPECTOR). Turns out we don't need the include at all and a forward declaration is enough. Patch coming.
Attachments
Patch. (1.37 KB, patch)
2010-06-17 10:54 PDT, Ben Murdoch 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Ben Murdoch
Comment 1 2010-06-17 10:54:12 PDT
Created attachment 59013 [details] Patch.
WebKit Commit Bot
Comment 2 2010-06-19 06:55:01 PDT
Comment on attachment 59013 [details] Patch. Clearing flags on attachment: 59013 Committed r61485: <http://trac.webkit.org/changeset/61485>
WebKit Commit Bot
Comment 3 2010-06-19 06:55:06 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.