Bug 40762

Summary: [DRT/Chromium] Add --allow-external-pages option
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Kent Tamura <tkent>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, dpranke
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: All   
Attachments:
Description Flags
Patch none

Kent Tamura
Reported 2010-06-17 00:56:14 PDT
[DRT/Chromium] Add --allow-external-pages option
Attachments
Patch (5.27 KB, patch)
2010-06-17 00:58 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-06-17 00:58:34 PDT
Created attachment 58968 [details] Patch
Dimitri Glazkov (Google)
Comment 2 2010-06-17 08:07:57 PDT
Dirk, do we need this upstream?
Dimitri Glazkov (Google)
Comment 3 2010-06-17 08:09:37 PDT
Comment on attachment 58968 [details] Patch Change looks fine.
Dirk Pranke
Comment 4 2010-06-17 16:31:50 PDT
No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. Given that we're not getting rid of TestShell at any point in the foreseeable future, I don't think we need to add it to DRT.
Kent Tamura
Comment 5 2010-06-17 16:37:44 PDT
(In reply to comment #4) > No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. I think this feature is nice to have. I sometimes want to see a render tree of external pages for debugging.
Kent Tamura
Comment 6 2010-06-20 21:39:05 PDT
Comment on attachment 58968 [details] Patch Clearing flags on attachment: 58968 Committed r61527: <http://trac.webkit.org/changeset/61527>
Kent Tamura
Comment 7 2010-06-20 21:39:13 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.