Summary: | [DRT/Chromium] Add --allow-external-pages option | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kent Tamura <tkent> | ||||
Component: | Tools / Tests | Assignee: | Kent Tamura <tkent> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | dglazkov, dpranke | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Other | ||||||
OS: | All | ||||||
Attachments: |
|
Description
Kent Tamura
2010-06-17 00:56:14 PDT
Created attachment 58968 [details]
Patch
Dirk, do we need this upstream? Comment on attachment 58968 [details]
Patch
Change looks fine.
No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. Given that we're not getting rid of TestShell at any point in the foreseeable future, I don't think we need to add it to DRT. (In reply to comment #4) > No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. I think this feature is nice to have. I sometimes want to see a render tree of external pages for debugging. Comment on attachment 58968 [details] Patch Clearing flags on attachment: 58968 Committed r61527: <http://trac.webkit.org/changeset/61527> All reviewed patches have been landed. Closing bug. |