Bug 40762

Summary:

[DRT/Chromium] Add --allow-external-pages option

Product:

WebKit

Reporter:

Kent Tamura <tkent>

Component:

Tools / Tests

Assignee:

Kent Tamura <tkent>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

dglazkov, dpranke

Priority:

Version:

528+ (Nightly build)

Hardware:

Other

OS:

All

Attachments:

Description	Flags
Patch	none

Description Kent Tamura 2010-06-17 00:56:14 PDT

[DRT/Chromium] Add --allow-external-pages option

Comment 1 Kent Tamura 2010-06-17 00:58:34 PDT

Created attachment 58968 [details]
Patch

Comment 2 Dimitri Glazkov (Google) 2010-06-17 08:07:57 PDT

Dirk, do we need this upstream?

Comment 3 Dimitri Glazkov (Google) 2010-06-17 08:09:37 PDT

Comment on attachment 58968 [details]
Patch

Change looks fine.

Comment 4 Dirk Pranke 2010-06-17 16:31:50 PDT

No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. 

Given that we're not getting rid of TestShell at any point in the foreseeable future, I don't think we need to add it to DRT.

Comment 5 Kent Tamura 2010-06-17 16:37:44 PDT

(In reply to comment #4)
> No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. 

I think this feature is nice to have.
I sometimes want to see a render tree of external pages for debugging.

Comment 6 Kent Tamura 2010-06-20 21:39:05 PDT

Comment on attachment 58968 [details]
Patch

Clearing flags on attachment: 58968

Committed r61527: <http://trac.webkit.org/changeset/61527>

Comment 7 Kent Tamura 2010-06-20 21:39:13 PDT

All reviewed patches have been landed.  Closing bug.