Bug 40762 - [DRT/Chromium] Add --allow-external-pages option
Summary: [DRT/Chromium] Add --allow-external-pages option
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other All
: P2 Normal
Assignee: Kent Tamura
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-06-17 00:56 PDT by Kent Tamura
Modified: 2010-06-20 21:39 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.27 KB, patch)
2010-06-17 00:58 PDT, Kent Tamura 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kent Tamura 2010-06-17 00:56:14 PDT 
[DRT/Chromium] Add --allow-external-pages option
Comment 1 Kent Tamura 2010-06-17 00:58:34 PDT 
Created attachment 58968 [details]
Patch
Comment 2 Dimitri Glazkov (Google) 2010-06-17 08:07:57 PDT 
Dirk, do we need this upstream?
Comment 3 Dimitri Glazkov (Google) 2010-06-17 08:09:37 PDT 
Comment on attachment 58968 [details]
Patch

Change looks fine.
Comment 4 Dirk Pranke 2010-06-17 16:31:50 PDT 
No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. 

Given that we're not getting rid of TestShell at any point in the foreseeable future, I don't think we need to add it to DRT.
Comment 5 Kent Tamura 2010-06-17 16:37:44 PDT 
(In reply to comment #4)
> No, we don't need this upstream. The feature was added to TestShell just because it was a binary we had that could load an arbitrary URL and take a screen capture of it. 

I think this feature is nice to have.
I sometimes want to see a render tree of external pages for debugging.
Comment 6 Kent Tamura 2010-06-20 21:39:05 PDT 
Comment on attachment 58968 [details]
Patch

Clearing flags on attachment: 58968

Committed r61527: <http://trac.webkit.org/changeset/61527>
Comment 7 Kent Tamura 2010-06-20 21:39:13 PDT 
All reviewed patches have been landed.  Closing bug.