Bug 40749

Summary:

ResourceLoader::willCacheResponse() needs to null-check m_frame->settings()

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

Page Loading

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

Keywords:

InRadar

Priority:

Version:

528+ (Nightly build)

Hardware:

Mac

OS:

All

Attachments:

Description	Flags
Patch v1 (null check and ASSERT)	eric.carlson: review+, beidson: commit-queue-

Brady Eidson

Reported 2010-06-16 17:14:06 PDT

ResourceLoader::willCacheResponse() needs to null-check m_frame->settings() We've seen crash reports at Apple (<rdar://problem/7249553>) where this method is called on a ResourceLoader, that belongs to a Frame, that no longer has a Page. Nominally, we think that any Frame without a Page shouldn't have loads occuring, but there is at least one code path where that is not the case, and it's proving elusive to figure out that code path by code inspection. Plenty of sites in the code null check frame->settings(), and we need to do so here to prevent this crash.

Attachments
Patch v1 (null check and ASSERT) (1.93 KB, patch) 2010-06-16 17:19 PDT, Brady Eidson	eric.carlson: review+ beidson: commit-queue-	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2010-06-16 17:19:47 PDT

Created attachment 58947 [details] Patch v1 (null check and ASSERT)

Brady Eidson

Comment 2 2010-06-16 17:28:17 PDT

http://trac.webkit.org/changeset/61296

Note You need to log in before you can comment on or make changes to this bug.