Bug 40737

Summary: SVGRenderSupport doesn't build due to removal of rootFilter from SVGRenderBase::prepareToRenderSVGContent
Product: WebKit Reporter: George Wright <gwright>
Component: SVGAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, krit
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
Remove UNUSED_PARAM(rootFilter) staikos: review+, commit-queue: commit-queue-

Description George Wright 2010-06-16 14:00:23 PDT
SVGRenderBase::prepareToRenderSVGContent used to have an additional parameter rootFilter which was removed in r60689, but UNUSED_PARAM() still references it, causing a build failure.
Comment 1 George Wright 2010-06-16 14:12:06 PDT
Created attachment 58936 [details]
Remove UNUSED_PARAM(rootFilter)
Comment 2 WebKit Commit Bot 2010-06-25 03:32:17 PDT
Comment on attachment 58936 [details]
Remove UNUSED_PARAM(rootFilter)

Rejecting patch 58936 from commit-queue.

Failed to run "[u'/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--reviewer', u'George Staikos', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/rendering/SVGRenderSupport.cpp
Hunk #1 FAILED at 86.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/rendering/SVGRenderSupport.cpp.rej

Full output: http://webkit-commit-queue.appspot.com/results/3297782
Comment 3 Dirk Schulze 2010-07-01 05:35:56 PDT
All unneeded filter vars were removed. Last commit: http://trac.webkit.org/changeset/62252

Closing bug.