Summary: | Add ENABLE_BLOB_BUILDER feature flag for BlobBuilder | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Kinuko Yasuda <kinuko> | ||||||
Component: | WebKit Misc. | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED INVALID | ||||||||
Severity: | Normal | CC: | dimich, fishd, jianli, levin | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | OS X 10.5 | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 40593 | ||||||||
Attachments: |
|
Description
Kinuko Yasuda
2010-06-16 13:52:38 PDT
Created attachment 58927 [details]
Patch
Created attachment 58930 [details]
Patch
Comment on attachment 58930 [details]
Patch
If BlobBuilder interface works for all platforms, why not making it enabled by default. This way, we do not need to have another feature flag to guard it.
I think the only thing is FileReader does not support reading the binary/hybrid blob created by BlobBuilder but it will get added soon. As long as FileReader throws an exception when encountering a non-file blob, I think it should be fine.
Right, I'll remove the ifdef guard for BlobBuilder (in my next patch) and close this one. Thanks. |