Bug 40664

Summary: Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, jamesr, mrobinson, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
Skipping for now none

Eric Seidel (no email)
Reported 2010-06-16 02:15:44 PDT
Gtk pumps the HTML5Lexer an extra time, causing inspector/timeline-script-tag-1.html to fail I'm not sure how the Gtk port is causing this, but the failure is pretty clear. Maybe Gtk is calling write() to write in some extra content to every page? Maybe Gtk has some very low tokenizerChunkSize? --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/inspector/timeline-script-tag-1-expected.txt 2010-06-16 01:35:54.000000000 -0700 +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/inspector/timeline-script-tag-1-actual.txt 2010-06-16 01:35:54.000000000 -0700 @@ -2,6 +2,7 @@ ParseHTML ParseHTML +ParseHTML ----> EvaluateScript --------> MarkTimeline : SCRIPT TAG EvaluateScript Properties: Going to skip the test for now until a Gtk person can look at it.
Attachments
Skipping for now (1.40 KB, patch)
2010-06-16 02:22 PDT, Eric Seidel (no email) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-16 02:22:59 PDT
Created attachment 58865 [details] Skipping for now
Eric Seidel (no email)
Comment 2 2010-06-16 02:24:08 PDT
Committed r61248: <http://trac.webkit.org/changeset/61248>
Martin Robinson
Comment 3 2011-02-09 17:15:21 PST
This no longer appears to be an issue. I've unskipped the test in http://trac.webkit.org/changeset/77967
Note You need to log in before you can comment on or make changes to this bug.