Bug 40659

Summary: Switch XSSAuditor over to using new entity parser
Product: WebKit Reporter: Adam Barth <abarth>
Component: New BugsAssignee: Adam Barth <abarth>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on:    
Bug Blocks: 39259    
Attachments:
Description Flags
wip
none
Patch eric: review-

Adam Barth
Reported 2010-06-16 01:12:37 PDT
Switch XSSAuditor over to using new entity parser
Attachments
wip (1.71 KB, patch)
2010-06-16 01:14 PDT, Adam Barth 		no flags
DetailsFormatted DiffDiff
Patch (2.01 KB, patch)
2010-06-16 01:27 PDT, Adam Barth 		eric: review-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Adam Barth
Comment 1 2010-06-16 01:14:13 PDT
Created attachment 58858 [details] wip
Adam Barth
Comment 2 2010-06-16 01:27:14 PDT
Created attachment 58860 [details] Patch
Eric Seidel (no email)
Comment 3 2010-06-16 01:30:44 PDT
Comment on attachment 58860 [details] Patch So this is not reflected in the tests in any way? There are certainly many more entities supported in HTML5 than in our old parser.
Adam Barth
Comment 4 2010-06-16 01:37:12 PDT
Yeah, but the two backend to the same entity list. Maybe we could use surrogate pairs?
Eric Seidel (no email)
Comment 5 2010-06-16 01:38:35 PDT
Does HTML5 support different entities in terms of &#x0000; style? I thought it supported longer or shorter lists of digits there?
Adam Barth
Comment 6 2010-06-16 01:48:20 PDT
Another possibility is CR, which think the old entity parser converted to LF.
Eric Seidel (no email)
Comment 7 2010-06-27 14:52:03 PDT
Comment on attachment 58860 [details] Patch no tests.
Adam Barth
Comment 8 2011-05-23 10:15:19 PDT
This happened a while ago!
Note You need to log in before you can comment on or make changes to this bug.