Bug 40635

Summary: Full screen video in Safari exits full-screen if you switch to another app
Product: WebKit Reporter: Jer Noble <jer.noble>
Component: New BugsAssignee: Jer Noble <jer.noble>
Status: RESOLVED FIXED    
Severity: Normal CC: eric
Priority: P2 Keywords: InRadar, PlatformOnly
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch eric.carlson: review+

Jer Noble
Reported 2010-06-15 13:49:46 PDT
Full screen video in Safari exits full-screen if you switch to another app
Attachments
Patch (3.11 KB, patch)
2010-06-15 14:04 PDT, Jer Noble 		no flags
DetailsFormatted DiffDiff
Patch (3.55 KB, patch)
2010-06-21 14:20 PDT, Jer Noble 		eric.carlson: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Jer Noble
Comment 1 2010-06-15 13:51:02 PDT
If on a dual screen setup you full screen an embedded HTML5 video, and then go to the other screen and try to bring up another window, the full screen video un-full screens.
Jer Noble
Comment 2 2010-06-15 13:52:40 PDT
<rdar://problem/7885101>
Jer Noble
Comment 3 2010-06-15 14:04:48 PDT
Created attachment 58816 [details] Patch
Mark Rowe (bdash)
Comment 4 2010-06-16 15:35:22 PDT
You’ll want to make sure that you remove the observer at some point too.
Jer Noble
Comment 5 2010-06-16 15:38:07 PDT
(In reply to comment #4) > You’ll want to make sure that you remove the observer at some point too. The observer is removed in -(void)dealloc, when [[NSNotificationCenter defaultCenter] removeObserver:self] is called. This removes all observers, regardless of key and object.
Eric Seidel (no email)
Comment 6 2010-06-21 13:36:03 PDT
Attachment 58816 [details] did not build on mac: Build output: http://webkit-commit-queue.appspot.com/results/3304529
Jer Noble
Comment 7 2010-06-21 14:20:51 PDT
Created attachment 59289 [details] Patch
Eric Carlson
Comment 8 2010-06-24 13:13:30 PDT
Comment on attachment 59289 [details] Patch WebKit/mac/WebView/WebVideoFullscreenController.mm:196 + - (void)applicationDidResignActive:(NSNotification*)notification Should have a space between type and * WebKit/mac/WebView/WebVideoFullscreenController.mm:200 + NSWindow* fullscreenWindow = [self fullscreenWindow]; Same here
Jer Noble
Comment 9 2010-06-24 16:29:12 PDT
Committed r61796: <http://trac.webkit.org/changeset/61796> Committed r61786: <http://trac.webkit.org/changeset/61786>
Jer Noble
Comment 10 2010-06-24 16:31:08 PDT
Disregard above comment. Committed r61796: <http://trac.webkit.org/changeset/61796>
Note You need to log in before you can comment on or make changes to this bug.