Bug 40603

Summary: Remove input parameter validation for "level" upper limit in *tex* functions
Product: WebKit Reporter: Zhenyao Mo <zmo>
Component: WebGLAssignee: Zhenyao Mo <zmo>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, commit-queue, dglazkov, gman, kbr, levin, oliver
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: OS X 10.5   
Bug Depends on: 38145    
Bug Blocks:    
Attachments:
Description Flags
patch none

Zhenyao Mo
Reported 2010-06-14 18:14:44 PDT
According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE). It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE). In this case, we should remove the code that checks the level upper limit.
Attachments
patch (2.04 KB, patch)
2010-06-14 18:24 PDT, Zhenyao Mo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Zhenyao Mo
Comment 1 2010-06-14 18:24:56 PDT
Created attachment 58738 [details] patch
David Levin
Comment 2 2010-06-15 00:00:10 PDT
(In reply to comment #0) > According to GLES 2.0.24 Spec, there is no hard limit as level < log2(MAX_TEXTURE_SIZE). It only says the maximum allowable width/height may be zero for image arrays of any level-of-detail greater than log2(MAX_TEXTURE_SIZE). > > In this case, we should remove the code that checks the level upper limit. Would have been nice to say some version of this in the ChangeLog (imo) as it would help anyone trying to understand why the change was done. Regardless, at least it is in the bug so they can't find it if needed.
WebKit Commit Bot
Comment 3 2010-06-17 09:39:48 PDT
Comment on attachment 58738 [details] patch Clearing flags on attachment: 58738 Committed r61332: <http://trac.webkit.org/changeset/61332>
WebKit Commit Bot
Comment 4 2010-06-17 09:39:52 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.