Summary: | Autogenerate most of the JS constructors | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||
Component: | WebCore JavaScript | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | abarth, alex, eric, mrobinson, ossy, webkit.review.bot, xan.lopez | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | PC | ||||||
OS: | OS X 10.5 | ||||||
Attachments: |
|
Description
Sam Weinig
2010-06-14 11:57:11 PDT
Created attachment 58686 [details]
patch
Comment on attachment 58686 [details]
patch
Sam, you are my WebKit Hacker of the Week.
Comment on attachment 58686 [details] patch You fixed bug 35140! > Fixes a bug where the new XSLTConstructor().toString() had a And EventSource! r=me http://trac.webkit.org/changeset/61136 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Chromium Linux Release (In reply to comment #5) > http://trac.webkit.org/changeset/61136 might have broken Qt Linux Release minimal, Qt Linux ARMv5 Release, Qt Linux ARMv7 Release, and Chromium Linux Release Rebaseline for Qt port landed in http://trac.webkit.org/changeset/61142. I think this caused global-constructors.html to fail for Gtk: --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-expected.txt 2010-06-14 18:55:20.000000000 -0700 +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-actual.txt 2010-06-14 18:55:20.000000000 -0700 @@ -44,6 +44,7 @@ PASS EntityReference.toString() is '[object EntityReferenceConstructor]' PASS Event.toString() is '[object EventConstructor]' PASS EventException.toString() is '[object EventExceptionConstructor]' +PASS EventSource.toString() is '[object EventSourceConstructor]' PASS File.toString() is '[object FileConstructor]' PASS FileList.toString() is '[object FileListConstructor]' PASS FormData.toString() is '[object FormDataConstructor]' @@ -298,6 +299,7 @@ PASS XPathEvaluator.toString() is '[object XPathEvaluatorConstructor]' PASS XPathException.toString() is '[object XPathExceptionConstructor]' PASS XPathResult.toString() is '[object XPathResultConstructor]' +PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]' PASS successfullyParsed is true TEST COMPLETE (In reply to comment #7) > I think this caused global-constructors.html to fail for Gtk: > --- /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-expected.txt 2010-06-14 18:55:20.000000000 -0700 > +++ /var/lib/buildbot/build/gtk-linux-32-release/build/layout-test-results/fast/js/global-constructors-actual.txt 2010-06-14 18:55:20.000000000 -0700 > @@ -44,6 +44,7 @@ > PASS EntityReference.toString() is '[object EntityReferenceConstructor]' > PASS Event.toString() is '[object EventConstructor]' > PASS EventException.toString() is '[object EventExceptionConstructor]' > +PASS EventSource.toString() is '[object EventSourceConstructor]' > PASS File.toString() is '[object FileConstructor]' > PASS FileList.toString() is '[object FileListConstructor]' > PASS FormData.toString() is '[object FormDataConstructor]' > @@ -298,6 +299,7 @@ > PASS XPathEvaluator.toString() is '[object XPathEvaluatorConstructor]' > PASS XPathException.toString() is '[object XPathExceptionConstructor]' > PASS XPathResult.toString() is '[object XPathResultConstructor]' > +PASS XSLTProcessor.toString() is '[object XSLTProcessorConstructor]' > PASS successfullyParsed is true > > TEST COMPLETE It seems we have a different expected for that test in gtk (not sure why) and it needs that modification. I'm going to upload a patch. |