Bug 40580

Summary: [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, jedrzej.nowacki
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Description Anders Bakken 2010-06-14 11:54:03 PDT 
[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Comment 1 Anders Bakken 2010-06-14 11:56:52 PDT 
Created attachment 58679 [details]
Patch
Comment 2 Anders Bakken 2010-06-14 12:04:30 PDT 
Created attachment 58680 [details]
Patch
Comment 3 Jędrzej Nowacki 2010-06-15 05:59:57 PDT 
Are you sure that we need to keep this function for different define values? Maybe we can remove it completely. According to an information in comment it should be safely to remove the function, because the bug (http://bugreports.qt.nokia.com/browse/QTBUG-7578) is closed.

Simon what do you think?
Comment 4 Adam Barth 2010-08-10 22:10:26 PDT 
Comment on attachment 58680 [details]
Patch

This patch looks ready to land.
Comment 5 WebKit Commit Bot 2010-08-10 22:40:22 PDT 
Comment on attachment 58680 [details]
Patch

Clearing flags on attachment: 58680

Committed r65124: <http://trac.webkit.org/changeset/65124>
Comment 6 WebKit Commit Bot 2010-08-10 22:40:26 PDT 
All reviewed patches have been landed.  Closing bug.