Bug 40580

Summary: [Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Product: WebKit Reporter: Anders Bakken <agbakken>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, hausmann, jedrzej.nowacki
Priority: P2 Keywords: Qt, QtTriaged
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Anders Bakken
Reported 2010-06-14 11:54:03 PDT
[Qt] Don't connect to microFocusChanged() if _q_updateMicroFocus is a noop.
Attachments
Patch (2.87 KB, patch)
2010-06-14 11:56 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Patch (3.56 KB, patch)
2010-06-14 12:04 PDT, Anders Bakken 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Anders Bakken
Comment 1 2010-06-14 11:56:52 PDT
Created attachment 58679 [details] Patch
Anders Bakken
Comment 2 2010-06-14 12:04:30 PDT
Created attachment 58680 [details] Patch
Jędrzej Nowacki
Comment 3 2010-06-15 05:59:57 PDT
Are you sure that we need to keep this function for different define values? Maybe we can remove it completely. According to an information in comment it should be safely to remove the function, because the bug (http://bugreports.qt.nokia.com/browse/QTBUG-7578) is closed. Simon what do you think?
Adam Barth
Comment 4 2010-08-10 22:10:26 PDT
Comment on attachment 58680 [details] Patch This patch looks ready to land.
WebKit Commit Bot
Comment 5 2010-08-10 22:40:22 PDT
Comment on attachment 58680 [details] Patch Clearing flags on attachment: 58680 Committed r65124: <http://trac.webkit.org/changeset/65124>
WebKit Commit Bot
Comment 6 2010-08-10 22:40:26 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.