| Summary: | Clean EFL includes from headers | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Component: | Platform | Assignee: | Lucas De Marchi <lucas.de.marchi> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | barbieri, commit-queue, eric, webkit.review.bot | ||||||
| Priority: | P2 | ||||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Other | ||||||||
| OS: | Linux | ||||||||
| Attachments: |
|
||||||||
|
Description
Lucas De Marchi
2010-06-14 09:42:09 PDT
Created attachment 58665 [details]
Patch
Attachment 58665 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/PlatformKeyboardEvent.h:66: Evas_Event_Key_Down is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformKeyboardEvent.h:67: Evas_Event_Key_Up is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/efl/WebCoreSupport/EditorClientEfl.h:40: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/graphics/Icon.h:43: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:37: Evas_Event_Mouse_Down is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:38: Evas_Event_Mouse_Up is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:39: Evas_Event_Mouse_Move is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:37: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:38: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformWheelEvent.h:36: Evas_Event_Mouse_Wheel is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/Widget.h:76: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/Widget.h:78: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.h:30: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 15 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
(In reply to comment #2) > Attachment 58665 [details] did not pass style-queue: > > Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" These style issues are either needed, because they name a type of EFL library or were not introduced by this patch (alphabetical sorting of headers). I've put Eric as CC since he is involved in cleaning header files in order to speed up compilation. Comment on attachment 58665 [details]
Patch
Sad to lose the type specificity of Evas_Button_Flags, but this looks fine.
Comment on attachment 58665 [details]
Patch
Forgot to remove the files from CMake. New patch is coming...
Created attachment 58722 [details]
Patch
Attachment 58722 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/platform/PlatformKeyboardEvent.h:66: Evas_Event_Key_Down is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformKeyboardEvent.h:67: Evas_Event_Key_Up is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/efl/WebCoreSupport/EditorClientEfl.h:40: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.cpp:53: Alphabetical sorting problem. [build/include_order] [4]
WebCore/platform/graphics/Icon.h:43: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:37: Evas_Event_Mouse_Down is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:38: Evas_Event_Mouse_Up is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformMouseEvent.h:39: Evas_Event_Mouse_Move is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:37: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.h:38: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/PlatformWheelEvent.h:36: Evas_Event_Mouse_Wheel is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/Widget.h:76: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/Widget.h:78: Ecore_Evas is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
WebCore/platform/efl/RenderThemeEfl.cpp:39: Alphabetical sorting problem. [build/include_order] [4]
WebKit/efl/WebCoreSupport/ChromeClientEfl.h:30: Evas_Object is incorrectly named. Don't use underscores in your identifier names. [readability/naming] [4]
Total errors found: 15 in 17 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 58722 [details]
Patch
OK.
Comment on attachment 58722 [details] Patch Clearing flags on attachment: 58722 Committed r61331: <http://trac.webkit.org/changeset/61331> All reviewed patches have been landed. Closing bug. |