| Summary: | Build error: WebCore.lib : fatal error LNK1106: invalid file or disk full. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Ada Chan <adachan> | ||||||||
| Component: | WebCore Misc. | Assignee: | Brian Weinstein <bweinstein> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | abarth, adachan, webkit.review.bot | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | PC | ||||||||||
| OS: | OS X 10.5 | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Ada Chan
2010-06-12 22:00:16 PDT
Created attachment 58580 [details]
Patch, sending this on behalf of Brian Weinstein
Attachment 58580 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:42: Alphabetical sorting problem. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:52: Alphabetical sorting problem. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:72: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 58582 [details]
Patch - fixing a few alphabetical sorting errors from last version
Attachment 58582 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:43: Alphabetical sorting problem. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:55: Alphabetical sorting problem. [build/include_order] [4]
WebCore/editing/EditingAllInOne.cpp:74: Alphabetical sorting problem. [build/include_order] [4]
Total errors found: 4 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 58582 [details]
Patch - fixing a few alphabetical sorting errors from last version
rs=me
Even though the style error message says “alphabetical sorting”, the #includes should be in ASCII order.
Created attachment 58583 [details]
Patch - take 3
Attachment 58583 [details] did not pass style-queue:
Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/editing/EditingAllInOne.cpp:28: Found other header before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Total errors found: 1 in 3 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 58583 [details]
Patch - take 3
rs=me again
Comment on attachment 58582 [details] Patch - fixing a few alphabetical sorting errors from last version Cleared Dan Bernstein's review+ from obsolete attachment 58582 [details] so that this bug does not appear in http://webkit.org/pending-commit. This patch appears to have been landed. |