Bug 40468

Summary:

Bindings scripts sanitization.

Product:

WebKit

Reporter:

Ilya Tikhonovsky <loislo>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

abarth, ap, cjerdonek, commit-queue, dglazkov, eric, pfeldman, yurys, zimmermann

Priority:

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[patch] initial version.	none

Ilya Tikhonovsky

Reported 2010-06-11 02:55:17 PDT

Perl scripts for bindings don't use strict rules. As result some errors in the code were not detected.

Attachments
[patch] initial version. (7.53 KB, patch) 2010-06-11 03:04 PDT, Ilya Tikhonovsky	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ilya Tikhonovsky

Comment 1 2010-06-11 03:04:20 PDT

Created attachment 58459 [details] [patch] initial version.

Eric Seidel (no email)

Comment 2 2010-06-11 08:20:44 PDT

Comment on attachment 58459 [details] [patch] initial version. Yay! Definitely better than before.

WebKit Commit Bot

Comment 3 2010-06-11 09:04:56 PDT

Comment on attachment 58459 [details] [patch] initial version. Clearing flags on attachment: 58459 Committed r61022: <http://trac.webkit.org/changeset/61022>

WebKit Commit Bot

Comment 4 2010-06-11 09:05:04 PDT

All reviewed patches have been landed. Closing bug.

Alexey Proskuryakov

Comment 5 2010-06-12 17:43:31 PDT

> As result some errors in the code were not detected. If these errors affected generated code, then this patch should have had regression tests.

Ilya Tikhonovsky

Comment 6 2010-06-14 04:00:45 PDT

(In reply to comment #5) > > As result some errors in the code were not detected. > > If these errors affected generated code, then this patch should have had regression tests. All the builds are the regression tests for these scripts. The real error has effect only for debug logging.

Note You need to log in before you can comment on or make changes to this bug.