Bug 40464

Summary:

[chromium] Clicking a login input field should open a popup with the saved logins

Product:

WebKit

Reporter:

Jay Civelli <jcivelli>

Component:

WebKit Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED WONTFIX

Severity:

Normal

CC:

abarth, dpranke, tim, tkent, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
First version	tkent: review-
Addressing tkent's comment	tkent: review+, eric: commit-queue-

Jay Civelli

Reported 2010-06-11 00:11:42 PDT

In order to make Chromium password autofill easier to use for users that have multiple accounts for a same site, clicking an input field should show the list of saved logins for that site.

Attachments
First version (6.34 KB, patch) 2010-06-11 00:50 PDT, Jay Civelli	tkent: review-	Details Formatted Diff Diff
Addressing tkent's comment (6.34 KB, patch) 2010-06-13 23:02 PDT, Jay Civelli	tkent: review+ eric: commit-queue-	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Jay Civelli

Comment 1 2010-06-11 00:50:10 PDT

Created attachment 58452 [details] First version

WebKit Review Bot

Comment 2 2010-06-11 10:24:38 PDT

Attachment 58452 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/src/DOMUtilitiesPrivate.h:49: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Dirk Pranke

Comment 3 2010-06-11 15:37:09 PDT

Comment on attachment 58452 [details] First version I'm not a reviewer, and I'm not an expert on this code, but this looks good to me.

Kent Tamura

Comment 4 2010-06-12 19:50:03 PDT

Comment on attachment 58452 [details] First version WebKit/chromium/public/WebPasswordAutocompleteListener.h:52 + virtual bool showSuggestionPopup(const string16& value) = 0; We should use WebString instead of string16 for WebKit API.

Jay Civelli

Comment 5 2010-06-13 23:02:02 PDT

Created attachment 58623 [details] Addressing tkent's comment

WebKit Review Bot

Comment 6 2010-06-13 23:03:56 PDT

Attachment 58623 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKit/chromium/src/DOMUtilitiesPrivate.h:49: Use 0 instead of NULL. [readability/null] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style.

Kent Tamura

Comment 7 2010-06-13 23:28:45 PDT

Comment on attachment 58623 [details] Addressing tkent's comment Please set commit-queue=? when Chromium side is ready.

Adam Barth

Comment 8 2010-08-10 22:07:49 PDT

This has been sitting in pending-commit for a while. Is the Chromium side ready?

Jay Civelli

Comment 9 2010-08-11 11:04:38 PDT

We are moving the password and form autofill code to Chromium so this bug and patch are now obsolete.

Note You need to log in before you can comment on or make changes to this bug.