Bug 40444

Summary: upload all patches that lack in-rietveld to rietveld
Product: WebKit Reporter: Ojan Vafai <ojan>
Component: New BugsAssignee: Ojan Vafai <ojan>
Status: RESOLVED FIXED    
Severity: Normal CC: eric, wsiegrist
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Exclude obsolete patches eric: review+

Ojan Vafai
Reported 2010-06-10 14:20:04 PDT
upload all patches that lack in-rietveld to rietveld
Attachments
Patch (4.07 KB, patch)
2010-06-10 14:21 PDT, Ojan Vafai 		no flags
DetailsFormatted DiffDiff
Exclude obsolete patches (4.36 KB, patch)
2010-06-10 15:09 PDT, Ojan Vafai 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Ojan Vafai
Comment 1 2010-06-10 14:21:26 PDT
Created attachment 58411 [details] Patch
Adam Barth
Comment 2 2010-06-10 14:54:50 PDT
Comment on attachment 58411 [details] Patch Have you looked to see how many patches this is? Could be a lot...
Ojan Vafai
Comment 3 2010-06-10 15:09:25 PDT
Created attachment 58417 [details] Exclude obsolete patches
Eric Seidel (no email)
Comment 4 2010-06-11 12:03:49 PDT
Comment on attachment 58417 [details] Exclude obsolete patches Please run this manually from your machine before changing the queue run on adams. :) Honestly, you should just run the rietvled queue on your machine so you can test edits like this. :)
Ojan Vafai
Comment 5 2010-06-11 12:22:45 PDT
I've been running this on my machine. There were 1200 patches. There are now ~300. It'll be caught up in ~3 hours.
Ojan Vafai
Comment 6 2010-06-11 16:21:47 PDT
The queue is now caught up. Does this patch seem OK?
Eric Seidel (no email)
Comment 7 2010-06-11 16:47:21 PDT
I feel for poor bugs.webkit.org. :p
Eric Seidel (no email)
Comment 8 2010-06-11 16:48:21 PDT
Comment on attachment 58417 [details] Exclude obsolete patches OK. Seems like we shouldn't ever bother to set in-reitveld=? now then. :)
Ojan Vafai
Comment 9 2010-06-11 16:55:17 PDT
Committed r61047: <http://trac.webkit.org/changeset/61047>
Note You need to log in before you can comment on or make changes to this bug.