Summary: | Avoid increasing required alignment of target type warning on ARM | ||
---|---|---|---|
Product: | WebKit | Reporter: | Gabor Loki <loki> |
Component: | JavaScriptCore | Assignee: | Gabor Loki <loki> |
Status: | RESOLVED DUPLICATE | ||
Severity: | Minor | ||
Priority: | P3 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | All | ||
OS: | All | ||
Attachments: |
Description
Gabor Loki
2010-06-10 02:17:41 PDT
Created attachment 58346 [details]
Avoid increasing required alignment of target type warning on ARM (part 1)
Each MacroAssembler back-end knows well if a natural alignment is required or not. So, leave them to handle the alignment.
An extra ASSERT for alignment check can cause a false positive error on those architectures where an unaligned data access is available. For example on x86: ASSERT(!(static_cast<unsigned int>(&m_buffer[m_size]) % WTF_ALIGN_OF(int64_t))).
Created attachment 58357 [details]
Avoid increasing required alignment of target type warning on ARM (part 2)
Fix the increasing required alignment of target type warnings in ARMAssembler.
Created attachment 58362 [details]
Avoid increasing required alignment of target type warning on ARM (part 3)
All static_cast can be safely done. Each data is aligned to target type.
Created attachment 58365 [details]
Avoid increasing required alignment of target type warning on ARM (part 4)
Qt specific fix for the alignment problem.
|