Bug 40408

Summary: Reduce FrameView.h includes to speed up build times
Product: WebKit Reporter: Eric Seidel (no email) <eric>
Component: New BugsAssignee: Eric Seidel (no email) <eric>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, dglazkov, eric, gustavo, webkit.review.bot, xan.lopez
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch abarth: review+, eric: commit-queue+

Eric Seidel (no email)
Reported 2010-06-10 01:18:33 PDT
Reduce FrameView.h includes to speed up build times
Attachments
Patch (14.38 KB, patch)
2010-06-10 01:22 PDT, Eric Seidel (no email) 		abarth: review+
eric: commit-queue+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Seidel (no email)
Comment 1 2010-06-10 01:22:47 PDT
Created attachment 58343 [details] Patch
Adam Barth
Comment 2 2010-06-10 01:26:09 PDT
Comment on attachment 58343 [details] Patch ok
Eric Seidel (no email)
Comment 3 2010-06-10 01:33:43 PDT
Committed r60943: <http://trac.webkit.org/changeset/60943>
WebKit Review Bot
Comment 4 2010-06-10 01:42:35 PDT
http://trac.webkit.org/changeset/60943 might have broken Chromium Linux Release The following changes are on the blame list: http://trac.webkit.org/changeset/60942 http://trac.webkit.org/changeset/60943
Eric Seidel (no email)
Comment 5 2010-06-10 01:54:37 PDT
Sigh. Probably me. Probably should have waited for the cr linux ews bot.
Eric Seidel (no email)
Comment 6 2010-06-10 01:58:55 PDT
Committed r60946: <http://trac.webkit.org/changeset/60946>
WebKit Review Bot
Comment 7 2010-06-10 02:04:21 PDT
Attachment 58343 [details] did not build on chromium: Build output: http://webkit-commit-queue.appspot.com/results/3224098
Eric Seidel (no email)
Comment 8 2010-06-10 02:06:26 PDT
Committed r60947: <http://trac.webkit.org/changeset/60947>
WebKit Review Bot
Comment 9 2010-06-10 02:12:15 PDT
Attachment 58343 [details] did not build on gtk: Build output: http://webkit-commit-queue.appspot.com/results/3233112
Eric Seidel (no email)
Comment 10 2010-06-10 02:14:58 PDT
Committed r60948: <http://trac.webkit.org/changeset/60948>
Eric Seidel (no email)
Comment 11 2010-06-10 02:22:13 PDT
Committed r60949: <http://trac.webkit.org/changeset/60949>
Eric Seidel (no email)
Comment 12 2010-06-10 02:32:17 PDT
Committed r60950: <http://trac.webkit.org/changeset/60950>
Note You need to log in before you can comment on or make changes to this bug.