Bug 40408 - Reduce FrameView.h includes to speed up build times
Summary: Reduce FrameView.h includes to speed up build times
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Eric Seidel (no email)
Depends on:
Reported: 2010-06-10 01:18 PDT by Eric Seidel (no email)
Modified: 2010-06-10 02:32 PDT (History)
6 users (show)

See Also:

Patch (14.38 KB, patch)
2010-06-10 01:22 PDT, Eric Seidel (no email)
abarth: review+
eric: commit-queue+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2010-06-10 01:18:33 PDT
Reduce FrameView.h includes to speed up build times
Comment 1 Eric Seidel (no email) 2010-06-10 01:22:47 PDT
Created attachment 58343 [details]
Comment 2 Adam Barth 2010-06-10 01:26:09 PDT
Comment on attachment 58343 [details]

Comment 3 Eric Seidel (no email) 2010-06-10 01:33:43 PDT
Committed r60943: <http://trac.webkit.org/changeset/60943>
Comment 4 WebKit Review Bot 2010-06-10 01:42:35 PDT
http://trac.webkit.org/changeset/60943 might have broken Chromium Linux Release
The following changes are on the blame list:
Comment 5 Eric Seidel (no email) 2010-06-10 01:54:37 PDT
Sigh.  Probably me.  Probably should have waited for the cr linux ews bot.
Comment 6 Eric Seidel (no email) 2010-06-10 01:58:55 PDT
Committed r60946: <http://trac.webkit.org/changeset/60946>
Comment 7 WebKit Review Bot 2010-06-10 02:04:21 PDT
Attachment 58343 [details] did not build on chromium:
Build output: http://webkit-commit-queue.appspot.com/results/3224098
Comment 8 Eric Seidel (no email) 2010-06-10 02:06:26 PDT
Committed r60947: <http://trac.webkit.org/changeset/60947>
Comment 9 WebKit Review Bot 2010-06-10 02:12:15 PDT
Attachment 58343 [details] did not build on gtk:
Build output: http://webkit-commit-queue.appspot.com/results/3233112
Comment 10 Eric Seidel (no email) 2010-06-10 02:14:58 PDT
Committed r60948: <http://trac.webkit.org/changeset/60948>
Comment 11 Eric Seidel (no email) 2010-06-10 02:22:13 PDT
Committed r60949: <http://trac.webkit.org/changeset/60949>
Comment 12 Eric Seidel (no email) 2010-06-10 02:32:17 PDT
Committed r60950: <http://trac.webkit.org/changeset/60950>