Bug 40402

Summary: [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
Product: WebKit Reporter: Kent Tamura <tkent>
Component: Tools / TestsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: dglazkov, eric, morrita, rolandsteiner, tony
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch
none
Patch (rev.2) none

Kent Tamura
Reported 2010-06-09 23:02:04 PDT
On Mac, "new-run-webkit-test --chromium --use-drt" doesn't work in Chromium tree. Linux and Windows seem to have the same problem. _build_path() in webkitpy/layout_test/port/chromium_*.py have a problem.
Attachments
Patch (4.33 KB, patch)
2010-06-10 00:18 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Patch (rev.2) (4.40 KB, patch)
2010-06-10 00:39 PDT, Kent Tamura 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kent Tamura
Comment 1 2010-06-09 23:07:49 PDT
NRWT tries to use src/third_party/WebKit/WebKit/chromium/xcodebuild/Debug/DumpRenderTree.app instead of src/xcodebuild/Debug/DumpRenderTree.app We need to use path_from_chromium_base() even if --use-drt is specified.
Tony Chang
Comment 2 2010-06-09 23:11:09 PDT
I think it would be ideal if we first tried src/third_party/WebKit/WebKit/chromium/xcodebuild/Debug/DumpRenderTree.app then fell back to src/xcodebuild/Debug/DumpRenderTree.app. For example, if I only have a chromium checkout, I sometimes use build-webkit --chromium in src/third_party/WebKit/ to make and test changes.
Kent Tamura
Comment 3 2010-06-10 00:18:14 PDT
Created attachment 58337 [details] Patch
Tony Chang
Comment 4 2010-06-10 00:37:50 PDT
LGTM (but I am not a reviewer)
Kent Tamura
Comment 5 2010-06-10 00:39:25 PDT
Created attachment 58340 [details] Patch (rev.2)
Dimitri Glazkov (Google)
Comment 6 2010-06-11 10:26:14 PDT
Comment on attachment 58340 [details] Patch (rev.2) ok.
Kent Tamura
Comment 7 2010-06-12 05:44:14 PDT
Comment on attachment 58340 [details] Patch (rev.2) Clearing flags on attachment: 58340 Committed r61061: <http://trac.webkit.org/changeset/61061>
Kent Tamura
Comment 8 2010-06-12 05:44:25 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.