Bug 40395

Summary: Image Resizer Patch 2: Adding basic resize functionality
Product: WebKit Reporter: Sterling Swigart <sswigart>
Component: ImagesAssignee: Nobody <webkit-unassigned>
Status: RESOLVED INVALID    
Severity: Normal CC: dimich, levin, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch 2
sswigart: review-, sswigart: commit-queue-
Waiting on patch 1, fixed a couple issues
sswigart: commit-queue-
Testing platform builds of ImageBuffer
none
Patch 2
none
Patch 2 none

Description Sterling Swigart 2010-06-09 17:19:59 PDT
Created attachment 58313 [details]
Patch 2

See Summary.
Comment 1 Sterling Swigart 2010-06-09 17:29:37 PDT
Oops, patch 1 has not been committed yet. I will resubmit the attachment after it is so that the files being patched exist...
Comment 2 David Levin 2010-06-09 17:39:16 PDT
A test comment to see if I get email on this bug.
Comment 3 Sterling Swigart 2010-06-09 18:39:02 PDT
Created attachment 58321 [details]
Waiting on patch 1, fixed a couple issues
Comment 4 Sterling Swigart 2010-06-11 08:06:13 PDT
Created attachment 58474 [details]
Testing platform builds of ImageBuffer
Comment 5 WebKit Review Bot 2010-06-11 08:08:23 PDT
Attachment 58474 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/ImageResizerThread.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 6 Sterling Swigart 2010-06-11 08:24:30 PDT
Created attachment 58478 [details]
Patch 2
Comment 7 WebKit Review Bot 2010-06-11 08:26:42 PDT
Attachment 58478 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1
WebCore/html/ImageResizerThread.cpp:39:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 8 Sterling Swigart 2010-06-11 08:59:05 PDT
Created attachment 58480 [details]
Patch 2
Comment 9 Sterling Swigart 2010-06-11 13:39:32 PDT
I am going to expose the function to javascript instead for patch 2. This bug will not be used in the future.