Bug 40360

Summary: Windows build break due to C4819 warning
Product: WebKit Reporter: Kwang Yul Seo <skyul>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED DUPLICATE    
Severity: Normal CC: tkent
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Windows XP   
Attachments:
Description Flags
Patch none

Kwang Yul Seo
Reported 2010-06-09 05:31:50 PDT
WKCAImageQueue.cpp and MediaPlayerPrivateFullscreenWindow.cpp contain non-ASCII double quotation marks around "AS IS". This causes C4819 warning in Korean version of Windows. I think it may cause the warning in some of non-English Windows too. Replace the double quotation mark with ``. 6>WKCAImageQueue.cpp 6>..\platform\graphics\win\WKCAImageQueue.cpp : error C2220: warning treated as error - no 'object' file generated 6>..\platform\graphics\win\WKCAImageQueue.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss 6>MediaPlayerPrivateFullscreenWindow.cpp 6>..\platform\graphics\win\MediaPlayerPrivateFullscreenWindow.cpp : error C2220: warning treated as error - no 'object' file generated 6>..\platform\graphics\win\MediaPlayerPrivateFullscreenWindow.cpp : warning C4819: The file contains a character that cannot be represented in the current code page (949). Save the file in Unicode format to prevent data loss
Attachments
Patch (2.48 KB, patch)
2010-06-09 05:34 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-06-09 05:34:02 PDT
Created attachment 58236 [details] Patch
Kent Tamura
Comment 2 2010-06-09 05:50:34 PDT
*** This bug has been marked as a duplicate of bug 40358 ***
David Levin
Comment 3 2010-06-09 08:59:45 PDT
Comment on attachment 58236 [details] Patch Already fixed in http://trac.webkit.org/changeset/60894 so I'm clearing the r?, etc.
Note You need to log in before you can comment on or make changes to this bug.