Bug 40346
| Summary: | Fix build breakage from 38145 | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Kenneth Russell <kbr> |
| Component: | WebGL | Assignee: | Kenneth Russell <kbr> |
| Status: | RESOLVED FIXED | ||
| Severity: | Normal | CC: | cmarrin, dglazkov, oliver, rolandsteiner, zmo |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | All | ||
| OS: | All | ||
| Bug Depends on: | 38145 | ||
| Bug Blocks: | |||
Kenneth Russell
The fix for bug 38145 broke the Chromium Win build because Microsoft's cmath doesn't define log2.
Suggested fix by zmo is to change log2(x) to log(x) / log(2).
Built and ran WebGL layout tests in Safari on Mac OS X.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Kenneth Russell
Committed r60876: <http://trac.webkit.org/changeset/60876>
Roland Steiner
The fix didn't catch - now the log function calls are ambiguous between float, double or long double versions.
I added a 2nd quick fix in r60881 - adding explicit casts to double and double constants - which seems to have done the trick, at least as far as compilation goes (see http://trac.webkit.org/changeset/60881)