Bug 40346 - Fix build breakage from 38145
Summary: Fix build breakage from 38145
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Kenneth Russell
URL:
Keywords:
Depends on: 38145
Blocks:
  Show dependency treegraph
 
Reported: 2010-06-08 19:01 PDT by Kenneth Russell
Modified: 2010-06-08 22:38 PDT (History)
5 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kenneth Russell 2010-06-08 19:01:42 PDT
The fix for bug 38145 broke the Chromium Win build because Microsoft's cmath doesn't define log2.

Suggested fix by zmo is to change log2(x) to log(x) / log(2).

Built and ran WebGL layout tests in Safari on Mac OS X.
Comment 1 Kenneth Russell 2010-06-08 19:11:50 PDT
Committed r60876: <http://trac.webkit.org/changeset/60876>
Comment 2 Roland Steiner 2010-06-08 22:38:58 PDT
The fix didn't catch - now the log function calls are ambiguous between float, double or long double versions.

I added a 2nd quick fix in r60881 - adding explicit casts to double and double constants - which seems to have done the trick, at least as far as compilation goes (see http://trac.webkit.org/changeset/60881)