Bug 40333

Summary: [GTK] Convert WebKitWebView's private draggingDataObjects member to a pointer
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: Linux   
Bug Depends on:    
Bug Blocks: 30623    
Attachments:
Description Flags
Convert draggingDataObjects to a pointer
none
Alternative approach using placement new
none
Patch where delete is done in finalize instead of dispose none

Martin Robinson
Reported 2010-06-08 14:14:37 PDT
Converting this member to a pointer will allow for calling constructor and destructor of this HashMap. Previously a 0'd memory region was used for this object.
Attachments
Convert draggingDataObjects to a pointer (4.63 KB, patch)
2010-06-08 14:19 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Alternative approach using placement new (1.72 KB, patch)
2010-06-09 14:10 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Patch where delete is done in finalize instead of dispose (4.87 KB, patch)
2010-07-01 08:43 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2010-06-08 14:19:33 PDT
Created attachment 58185 [details] Convert draggingDataObjects to a pointer
Martin Robinson
Comment 2 2010-06-09 14:10:49 PDT
Created attachment 58295 [details] Alternative approach using placement new
Martin Robinson
Comment 3 2010-06-29 09:23:40 PDT
Comment on attachment 58185 [details] Convert draggingDataObjects to a pointer It seems like the pointer approach is preferred, so I'm re-enabling the review? flag on it.
Xan Lopez
Comment 4 2010-06-30 13:06:47 PDT
Comment on attachment 58185 [details] Convert draggingDataObjects to a pointer Looks good.
Martin Robinson
Comment 5 2010-06-30 22:45:18 PDT
Committed r62226: <http://trac.webkit.org/changeset/62226>
WebKit Review Bot
Comment 6 2010-06-30 23:13:04 PDT
http://trac.webkit.org/changeset/62226 might have broken GTK Linux 32-bit Release
Martin Robinson
Comment 7 2010-06-30 23:25:19 PDT
Reverted r62226 for reason: This change caused 13 new crashers. Committed r62230: <http://trac.webkit.org/changeset/62230>
Martin Robinson
Comment 8 2010-07-01 08:43:28 PDT
Created attachment 60253 [details] Patch where delete is done in finalize instead of dispose
Xan Lopez
Comment 9 2010-07-01 08:57:43 PDT
Comment on attachment 60253 [details] Patch where delete is done in finalize instead of dispose 13 crashers!
Martin Robinson
Comment 10 2010-07-01 09:03:12 PDT
Comment on attachment 60253 [details] Patch where delete is done in finalize instead of dispose Clearing flags on attachment: 60253 Committed r62262: <http://trac.webkit.org/changeset/62262>
Martin Robinson
Comment 11 2010-07-01 09:03:18 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.