Bug 40330

Summary: [Qt] Add support for callShouldCloseOnWebView() to DRT
Product: WebKit Reporter: Robert Hogan <robert>
Component: New BugsAssignee: Robert Hogan <robert>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Attachments:
Description Flags
Patch eric: review+

Robert Hogan
Reported 2010-06-08 13:41:59 PDT
[Qt] Add support for callShouldCloseOnWebView() to DRT
Attachments
Patch (6.26 KB, patch)
2010-06-08 13:45 PDT, Robert Hogan 		eric: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Robert Hogan
Comment 1 2010-06-08 13:45:40 PDT
Created attachment 58176 [details] Patch
Eric Seidel (no email)
Comment 2 2010-06-12 19:01:41 PDT
Comment on attachment 58176 [details] Patch Why the void setCallCloseOnWebViews() {} change? Seems unrelated. please remove if not needed.
Robert Hogan
Comment 3 2010-06-13 03:22:18 PDT
(In reply to comment #2) > (From update of attachment 58176 [details]) > Why the void setCallCloseOnWebViews() {} change? Seems unrelated. please remove if not needed. On Qt I think it just needs to be supported as a no-op. Adding it also allows the real DRT bug in plugins/open-and-close-window-with-plugin.html and plugins/geturlnotify-during-document-teardown.html to be exposed. This is tracked at https://bugs.webkit.org/show_bug.cgi?id=33333. I'll add a comment to it so people know why it's there.
Robert Hogan
Comment 4 2010-06-13 06:30:10 PDT
Committed r61090: <http://trac.webkit.org/changeset/61090>
Note You need to log in before you can comment on or make changes to this bug.