Bug 40324 – [Qt] DRT EventSender support to graphics context events

• Component: Tools / Tests
• Status: RESOLVED FIXED

[Diego Gonzalez]

Make possible to run context menu test in graphics based view mode

[Diego Gonzalez]

Created attachment 58490 [details]
Patch

[Antonio Gomes]

(In reply to comment #1)
> Created an attachment (id=58490) [details]
> Patch

lgtm

[Kenneth Rohde Christiansen]

Comment on attachment 58490 [details]
Patch

WebKitTools/DumpRenderTree/qt/EventSenderQt.cpp:347
 +          WebCore::WebViewGraphicsBased* view = qobject_cast<WebCore::WebViewGraphicsBased*>(m_page->view());
as you sure this is right? We normally do not set the view when dealing with QGraphicsWebView. And even if you set it, it seems like a hack. It would be nice to do this in another way

Anyway, looks fine.

[Diego Gonzalez]

Comment on attachment 58490 [details]
Patch

Just to do some tests

[WebKit Commit Bot]

Comment on attachment 58490 [details]
Patch

Clearing flags on attachment: 58490

Committed r61184: <http://trac.webkit.org/changeset/61184>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[WebKit Review Bot]

http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal

[Antonio Gomes]

(In reply to comment #7)
> http://trac.webkit.org/changeset/61184 might have broken Qt Linux Release minimal

diego, you possibly need this  #ifndef QT_NO_CONTEXTMENU wrapping the code