Bug 40322

Summary: Update readPixels to take ArrayBufferView rather than returning it
Product: WebKit Reporter: Kenneth Russell <kbr>
Component: WebGLAssignee: Kenneth Russell <kbr>
Status: RESOLVED FIXED    
Severity: Normal CC: cmarrin, dglazkov, kbr, oliver, zmo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
kbr: commit-queue-
Revised patch dglazkov: review+, kbr: commit-queue-

Kenneth Russell
Reported 2010-06-08 12:08:56 PDT
Per recent updates to the WebGL spec, readPixels must be updated to take an ArrayBufferView as argument rather than returning a newly allocated one. Checks on the type and size of the passed array must be implemented.
Attachments
Patch (26.43 KB, patch)
2010-06-09 14:06 PDT, Kenneth Russell 		kbr: commit-queue-
DetailsFormatted DiffDiff
Revised patch (26.41 KB, patch)
2010-06-09 14:10 PDT, Kenneth Russell 		dglazkov: review+
kbr: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Kenneth Russell
Comment 1 2010-06-09 11:45:56 PDT
I've already got a patch in progress for this one. Reassigning to myself.
Kenneth Russell
Comment 2 2010-06-09 14:06:46 PDT
Created attachment 58293 [details] Patch Self-explanatory. Ran WebGL tests in WebKit; testing in Chromium in progress and will be completed before checkin.
Kenneth Russell
Comment 3 2010-06-09 14:10:33 PDT
Created attachment 58294 [details] Revised patch Fixed minor style issue in read-pixels.html test.
Dimitri Glazkov (Google)
Comment 4 2010-06-09 14:12:49 PDT
Comment on attachment 58294 [details] Revised patch ok.
Kenneth Russell
Comment 5 2010-06-09 14:40:03 PDT
Committed r60914: <http://trac.webkit.org/changeset/60914>
Note You need to log in before you can comment on or make changes to this bug.