Summary: | [GTK] DragDataGtk should use DataObjectGtk as the platformDragData | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Martin Robinson <mrobinson> | ||||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | ||||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | PC | ||||||||
OS: | Linux | ||||||||
Bug Depends on: | |||||||||
Bug Blocks: | 30623, 39843 | ||||||||
Attachments: |
|
Description
Martin Robinson
2010-06-08 10:25:28 PDT
Created attachment 58161 [details]
Patch
Comment on attachment 58161 [details]
Patch
WebCore/platform/DragData.h:
+ typedef void* DragDataRef;
Can't this just be class DataObjectGtk; instead of having to include the header?
WebCore/platform/gtk/DragDataGtk.cpp:93
+ RefPtr<DocumentFragment> fragment(createFragmentFromMarkup(document, m_platformDragData->markup(), ""));
Why store this in a ref ptr at all?
Created attachment 58735 [details]
Patch with Eric's suggestions
(In reply to comment #2) Thank you for your review. I've incorporated both of your suggestions in a new patch. Comment on attachment 58735 [details]
Patch with Eric's suggestions
Correctomundo.
Comment on attachment 58735 [details] Patch with Eric's suggestions Clearing flags on attachment: 58735 Committed r62124: <http://trac.webkit.org/changeset/62124> All reviewed patches have been landed. Closing bug. |