Bug 40290

Summary: Android V8 seems to need to include V8Proxy.h in gnerated bindings code
Product: WebKit Reporter: Leon Clarke <leonclarke>
Component: WebCore Misc.Assignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, jorlow, steveblock
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Android   
OS: Android   
Attachments:
Description Flags
Patch none

Description Leon Clarke 2010-06-08 03:34:46 PDT
...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
Comment 1 Steve Block 2010-06-08 05:00:11 PDT
(In reply to comment #0)
> ...for toV8Context(ScriptExecutionContext*, constWorldContextHandle&);
toV8Context() is defined in V8Proxy.h, so it looks to me like  GenerateCallbackImplementation in CodeGeneratorV8.pm should add this include.
Comment 2 Steve Block 2010-06-08 05:08:52 PDT
Created attachment 58130 [details]
Patch
Comment 3 Jeremy Orlow 2010-06-08 05:32:56 PDT
Comment on attachment 58130 [details]
Patch

r=me
Comment 4 WebKit Commit Bot 2010-06-09 19:41:04 PDT
Comment on attachment 58130 [details]
Patch

Clearing flags on attachment: 58130

Committed r60931: <http://trac.webkit.org/changeset/60931>
Comment 5 WebKit Commit Bot 2010-06-09 19:41:09 PDT
All reviewed patches have been landed.  Closing bug.