Bug 40285

Summary: [chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
Product: WebKit Reporter: Tony Chang <tony>
Component: New BugsAssignee: Tony Chang <tony>
Status: RESOLVED FIXED    
Severity: Normal CC: abarth, eric, evan, webkit.review.bot
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Other   
OS: OS X 10.5   
Bug Depends on: 40349    
Bug Blocks:    
Attachments:
Description Flags
Patch levin: review+

Tony Chang
Reported 2010-06-07 23:57:41 PDT
[chromium] compile linux chromium in WebKit/out instead of WebKit/WebKit/chromium/out
Attachments
Patch (4.37 KB, patch)
2010-06-07 23:58 PDT, Tony Chang 		levin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tony Chang
Comment 1 2010-06-07 23:58:07 PDT
Created attachment 58117 [details] Patch
Tony Chang
Comment 2 2010-06-08 00:03:47 PDT
Chromium Linux is currently built in WebKit/WebKit/chromium/out from a Makefile that is generated into WebKit/WebKit/chromium/Makefile. This causes problems, because the Makefile that is generated builds relative paths to .cpp files. This results in some files being compiled outside of the target directory. For example, when building libwebcore.a, it places the file in WebKit/WebKit/chromium/out/WebCore/libwebcore.a instead of, say, WebKit/WebKit/chromium/out/Debug/obj.target/WebCore/libwebcore.a. This causes problems because it tries to put the debug and release .a file in the same place and switching from debug to release can cause weird link errors. Anyway, this patch is to move from generating WebKit/WebKit/chromium/Makefile to generating WebKit/Makefile.chromium and building at the root of the source tree. Since this changes the output path, there's a small change to new-run-webkit-tests.
Tony Chang
Comment 3 2010-06-08 21:05:25 PDT
Committed r60878: <http://trac.webkit.org/changeset/60878>
WebKit Review Bot
Comment 4 2010-06-08 21:19:45 PDT
http://trac.webkit.org/changeset/60878 might have broken Chromium Linux Release
Tony Chang
Comment 5 2010-06-08 21:32:45 PDT
Reverted because this broke the linux build.
Tony Chang
Comment 6 2010-06-09 00:23:02 PDT
Committed r60884: <http://trac.webkit.org/changeset/60884>
Tony Chang
Comment 7 2010-06-09 00:40:49 PDT
(In reply to comment #6) > Committed r60884: <http://trac.webkit.org/changeset/60884> Yay, this actually worked.
Tony Chang
Comment 8 2010-07-14 13:10:50 PDT
*** Bug 37969 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.