| Summary: | [Qt] SmartReplaceQt.cpp has coding-style errors | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Anders Bakken <agbakken> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Trivial | CC: | abarth, benjamin, commit-queue, eric, jedrzej.nowacki, webkit.review.bot | ||||||
| Priority: | P5 | Keywords: | EasyFix, Qt, QtTriaged | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Attachments: |
|
||||||||
|
Description
Anders Bakken
2010-06-07 13:07:16 PDT
Created attachment 58079 [details]
Patch
Comment on attachment 58079 [details] Patch >+ No new tests. (OOPS!) :( I don't like it, it destroys history of changes. I think it is not in the we work with webkit, general policy is that code shouldn't be changed only for a style reason. Personally I preferred previous version, but you are right, it is not webkit style. If you do want to make a fix, please change comments, they should be full phrases with point at the end. (In reply to comment #2) > (From update of attachment 58079 [details]) > >+ No new tests. (OOPS!) > :( The change don't need tests. Created attachment 88247 [details]
Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp
Comment on attachment 88247 [details] Fixing previous patch submitted by Anders Bakken to fix the coding-style on SmartReplaceQt.cpp Clearing flags on attachment: 88247 Committed r83029: <http://trac.webkit.org/changeset/83029> All reviewed patches have been landed. Closing bug. The commit-queue encountered the following flaky tests while processing attachment 88247 [details]: animations/suspend-resume-animation.html bug 48161 (author: cmarrin@apple.com) The commit-queue is continuing to process your patch. http://trac.webkit.org/changeset/83029 might have broken GTK Linux 32-bit Debug |