Bug 40237 – [Qt] QtWebKit exports WebCore symbols

• Component: New Bugs
• Status: RESOLVED INVALID

[Felix Geyer]

Created attachment 58036 [details]
Patch to reduce visibility similar to the JavaScriptCore commit

QtWebKit exports the WebCore symbols when building as a standalone package.

Previously the JavaScriptCore symbols were exported too.
This has been fixed by this commit:
http://trac.webkit.org/changeset/58100/trunk/JavaScriptCore/JavaScriptCore.pro

The same should be done in WebCore.

[Jocelyn Turcotte]

Looks good to me.

The CONFIG(standalone_package) condition should clearly be removed since we will start getting releases separated from Qt.

If you want a reviewer to look at your patch you should set the review flag of the attachment to '?' (and the commit queue flag to '?' if you want it to be landed automatically)

[Eric Seidel (no email)]

Comment on attachment 58036 [details]
Patch to reduce visibility similar to the JavaScriptCore commit

Please generate the patch from a WebKit checkout, and include a ChangeLog per our contribution guidelines:
http://webkit.org/coding/contributing.html

webkit-patch upload
is one script which can help you make sure you're following the guildes.

[Jocelyn Turcotte]

=== Bulk closing of Qt bugs ===

If you believe that this bug report is still relevant for a non-Qt port of webkit.org, please re-open it and remove [Qt] from the summary.

If you believe that this is still an important QtWebKit bug, please fill a new report at https://bugreports.qt-project.org and add a link to this issue. See http://qt-project.org/wiki/ReportingBugsInQt for additional guidelines.