Bug 40169

Summary:

Android makefiles always rebuild stuff

Product:

WebKit

Reporter:

Leon Clarke <leonclarke>

Component:

WebCore Misc.

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, jorlow, webkit.review.bot

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

OS X 10.5

Attachments:

Description	Flags
Proposed fix	jorlow: review+, commit-queue: commit-queue-
Added a changelog this time. Oops. Also the previous patch was actually missing an include directory.	jorlow: review+, jorlow: commit-queue-
One of these days I'll get this right	jorlow: review+, jorlow: commit-queue-
Try again	none

Leon Clarke

Reported 2010-06-04 08:57:08 PDT

due to a tab being a set of spaces

Attachments
Proposed fix (1.90 KB, patch) 2010-06-04 08:58 PDT, Leon Clarke	jorlow: review+ commit-queue: commit-queue-	Details Formatted Diff Diff
Added a changelog this time. Oops. Also the previous patch was actually missing an include directory. (2.70 KB, patch) 2010-06-07 03:44 PDT, Leon Clarke	jorlow: review+ jorlow: commit-queue-	Details Formatted Diff Diff
One of these days I'll get this right (2.74 KB, patch) 2010-06-07 04:01 PDT, Leon Clarke	jorlow: review+ jorlow: commit-queue-	Details Formatted Diff Diff
Try again (2.75 KB, patch) 2010-06-07 04:20 PDT, Leon Clarke	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Leon Clarke

Comment 1 2010-06-04 08:58:01 PDT

Created attachment 57885 [details] Proposed fix

Jeremy Orlow

Comment 2 2010-06-04 09:00:36 PDT

Comment on attachment 57885 [details] Proposed fix Sorry! r=me

WebKit Commit Bot

Comment 3 2010-06-04 20:27:12 PDT

Comment on attachment 57885 [details] Proposed fix Rejecting patch 57885 from commit-queue. Found no modified ChangeLogs, cannot create a commit message. All changes require a ChangeLog. See: http://webkit.org/coding/contributing.html

Leon Clarke

Comment 4 2010-06-07 03:44:55 PDT

Created attachment 58007 [details] Added a changelog this time. Oops. Also the previous patch was actually missing an include directory.

Jeremy Orlow

Comment 5 2010-06-07 03:52:04 PDT

Comment on attachment 58007 [details] Added a changelog this time. Oops. Also the previous patch was actually missing an include directory. > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 60772) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,13 @@ > +2010-06-07 Leon Clarke <leonclarke@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Fix indexeddb idls in android makefile You forgot the URL. r=me

Leon Clarke

Comment 6 2010-06-07 04:01:02 PDT

Created attachment 58010 [details] One of these days I'll get this right

WebKit Review Bot

Comment 7 2010-06-07 04:01:47 PDT

Attachment 58010 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/ChangeLog:6: Line contains tab character. [whitespace/tab] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.

Jeremy Orlow

Comment 8 2010-06-07 04:04:50 PDT

Comment on attachment 58010 [details] One of these days I'll get this right > Index: WebCore/ChangeLog > =================================================================== > --- WebCore/ChangeLog (revision 60772) > +++ WebCore/ChangeLog (working copy) > @@ -1,3 +1,14 @@ > +2010-06-07 Leon Clarke <leonclarke@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Fix indexeddb idls in android makefile > + https://bugs.webkit.org/show_bug.cgi?id=40169 Not spaced in right. :-)

Leon Clarke

Comment 9 2010-06-07 04:20:53 PDT

Created attachment 58012 [details] Try again

Jeremy Orlow

Comment 10 2010-06-07 04:22:43 PDT

Comment on attachment 58012 [details] Try again r=me

WebKit Commit Bot

Comment 11 2010-06-07 05:33:02 PDT

Comment on attachment 58012 [details] Try again Clearing flags on attachment: 58012 Committed r60777: <http://trac.webkit.org/changeset/60777>

WebKit Commit Bot

Comment 12 2010-06-07 05:33:08 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.